Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Dec 20, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

arnaud-lb and others added 5 commits December 20, 2024 18:45
When observer is enabled, we normally add an extra temporary to all
functions, to store the previously observed frame. However, this is done in
zend_observer_post_startup() so it doesn't happen to dl'ed() functions.

One possible fix would be to move that from zend_observer_post_startup()
to zend_register_functions(), but this would be too early: Observer may
not be enabled when zend_register_functions() is called, and may still be
enabled later.

However, when zend_register_functions() is called at run-time (during dl()),
we know definitively whether observer is enabled.

Here I update zend_register_functions() to add a temporary to dl'ed()
functions when observer is enabled.

Fixes: GH-17211
Closes: GH-17220
* PHP-8.2:
  Add observer temporary to dl'ed functions
* PHP-8.3:
  Add observer temporary to dl'ed functions
* PHP-8.4:
  Add observer temporary to dl'ed functions
@pull pull bot added the ⤵️ pull label Dec 20, 2024
@pull pull bot merged commit c4bb6e6 into wudi:master Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants